Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JobsListTests GWT unit test very slow #6613

Closed
gtritchie opened this issue Apr 8, 2020 · 0 comments · Fixed by #6657
Closed

JobsListTests GWT unit test very slow #6613

gtritchie opened this issue Apr 8, 2020 · 0 comments · Fixed by #6657
Labels
automation tech debt internal tech debt with no direct benefit to customer.

Comments

@gtritchie
Copy link
Member

#6352 # System details

RStudio Edition : Server (dev)
RStudio Version : master after merging #6592
OS Version      : any
R Version       : any

Steps to reproduce the problem

Build and run ant unittest

Describe the problem in detail

Tests take upwards of 2 minutes to run.

Describe the behavior you expected

Prior to merging PR #6592 (custom fonts for RStudio Server) these were taking ~< 20 seconds to run.

The problem is that the JobsListTests suite is creating UI, which in turn causes calls to static WebThemeFontLoader.getFixedWidthFont(), which makes direct injector calls to get SessionInfo and UserPrefs. We shouldn't be doing this in unit tests. Ideally we'd refactor to avoid creating UI in our unit tests, and/or not be making direct injector calls like this but instead using mocked versions.

See #4460 for a previous set of fixes for this type of issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation tech debt internal tech debt with no direct benefit to customer.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant