fallback to searching for object "anywhere"

[sharon-wang]

Intent

Addresses:

• Data preview fails for data.frames that are part of another object #13291

Approach

The existing code passes an env + obj combination that will not result in the object being found.

In this PR:

• we already fallback to looking for the data "anywhere" in .rs.getHelpDataFrame
  • when we do this, don't include the env when constructing the gridviewer uri, because the data was found "anywhere"
• in DataViewer.cpp, if we can't find the data frame using existing methods, try to find it "anywhere" before giving up and erroring

Using this repro:

test_df <- data.frame(col1 = rep(1, 3),
                      col2 = rep(2, 3),
                      col3 = rep(3, 3))

test_ls <- list(a = test_df,
                b = test_df)

# type `test_ls$` to trigger help preview

	current	this PR
env uri param	test_ls	empty
obj uri param	a	test_ls$a
result	can't find a in test_ls (test_ls is not an environment)	finds test_ls$a "anywhere"

Automated Tests

none

QA Notes

In addition to the repro steps from #13291, I tested an additional nesting layer:

test_df <- data.frame(col1 = rep(1, 3),
                      col2 = rep(2, 3),
                      col3 = rep(3, 3))

test_ls <- list(a = test_df,
                b = test_df)

test_nest <- list(x = test_ls, y = test_ls, z = test_df)

# trigger help preview for the following:
# test_ls$
# test_nest$
# test_nest$x$a
# test_nest$z

Documentation

none

Checklist

• If this PR adds a new feature, or fixes a bug in a previously released version, it includes an entry in NEWS.md
  - [ ] If this PR adds or changes UI, the updated UI meets accessibility standards
• A reviewer is assigned to this PR (if unsure who to assign, check Area Owners list)
• This PR passes all local unit tests

[kevinushey]

LGTM!