upgrade to Qt 5.9.2 + Qt WebEngine #1720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Created package with only the bits needed for building, put up on buildtools. - Also created an equivalent 5.9.3 package (for Mac), but not using it yet. - Fixed error on High Sierra with install-dependencies-osx configuring PAM
Qt does extra Mac stuff to determine the menu shown for focused window. Creating via QMenuBar() causes the placeholder menu to become the default for all windows; creating via QMenuBar(this) causes it to be associated with the current window, and it gets cleaned up later via menuBarCompleted signal and replaced with real menu bar (for all windows).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Not ready for merge but putting this up for initial review + organization.
This PR seeks to update Qt to 5.9.2, and alongside that port our existing Qt code base from the older, deprecated QtWebKit to the newer QtWebEngine. In this PR, we seek only to upgrade the Linux + Windows desktop components; migrating macOS to QtWebEngine will be explored in a later PR.