Fix build issues with clang6. #2794
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submitted by Thomas Mueller <thmu7@freenet.de> in the FreeBSD bug report: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=228289
|
LGTM; I'll let @jmcphers take a final look and merge if all looks well. |
|
Please test it with clang5 and clang6 before merging. It is possibly related to #2289 Somebody innately familiar with the rstudio code should test and fix both issues. |
|
This change breaks most of our builds, with the same error named in the FreeBSD bug report (re: clang5 compilation). |
|
Those attempts to assign |
|
Could you alter the patch and fix these clang5/clang6 build issues? |
|
Superceded by #2807. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submitted by Thomas Mueller thmu7@freenet.de in the FreeBSD bug report: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=228289