Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring so GWT unit tests run less slowly #4460

Merged
merged 10 commits into from
Mar 18, 2019
Merged

Refactoring so GWT unit tests run less slowly #4460

merged 10 commits into from
Mar 18, 2019

Commits on Mar 14, 2019

  1. refactor construction of VirtualConsole to avoid triggering injection… 

    … during unit tests

- this is part of a series of refactorings needed to make `ant unittest` not take FOREVER
- unit tests should not be using GIN under the covers, all arguments should be supplied by the unit tests, both for performance reasons and for testability reasons
    @gtritchie
    gtritchie committed Mar 14, 2019
    Configuration menu
    Copy the full SHA
    79879f7 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2019

  1. Merge branch 'master' into bugfix/speed-up-gwt-unittests

    @gtritchie
    gtritchie committed Mar 15, 2019
    Configuration menu
    Copy the full SHA
    9f8d1e3 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'v1.3' into bugfix/speed-up-gwt-unittests

    @gtritchie
    gtritchie committed Mar 15, 2019
    Configuration menu
    Copy the full SHA
    7209b3c View commit details
    Browse the repository at this point in the history

  3. move VirtualConsole factory and preferences implementation from core … 

    …to client

- core isn't supposed to depend on client, though this is far from the only offender
    @gtritchie
    gtritchie committed Mar 15, 2019
    Configuration menu
    Copy the full SHA
    6cdbcf4 View commit details
    Browse the repository at this point in the history

  4. shorten factory method to create

    @gtritchie
    gtritchie committed Mar 15, 2019
    Configuration menu
    Copy the full SHA
    cecdb3c View commit details
    Browse the repository at this point in the history

  5. fix ConsoleOutputWriter unit tests to avoid heavy injection

    @gtritchie
    gtritchie committed Mar 15, 2019
    Configuration menu
    Copy the full SHA
    5098564 View commit details
    Browse the repository at this point in the history

  6. fix JobListTests to avoid triggering dependency injection

    @gtritchie
    gtritchie committed Mar 15, 2019
    Configuration menu
    Copy the full SHA
    5cd60a3 View commit details
    Browse the repository at this point in the history

  7. remove incorrect comment

    @gtritchie
    gtritchie committed Mar 15, 2019
    Configuration menu
    Copy the full SHA
    a826bb3 View commit details
    Browse the repository at this point in the history

  8. add missing file comment block

    @gtritchie
    gtritchie committed Mar 15, 2019
    Configuration menu
    Copy the full SHA
    3dfcacd View commit details
    Browse the repository at this point in the history

  9. Merge branch 'v1.3' into bugfix/speed-up-gwt-unittests

    @gtritchie
    gtritchie committed Mar 15, 2019
    Configuration menu
    Copy the full SHA
    31b2d66 View commit details
    Browse the repository at this point in the history