enable <!-- --> comments for Markdown #482
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(NOTE: not quite ready for merge)
This PR:
Rewrites the
doCommentUncomment()
method to be line-by-line, rather than targeted on a whole selection (using regexes). This makes it easier to control how commenting works for 'double-sided' comments and also makes it a bit easier to handle what happens when considering commenting a line containing only whitespace.Using the above, enables
<!-- -->
comments for Markdown modes.As is tradition, a GIF showing this in action in an R Markdown document. Note that lines containing only whitespace within a selection are commented when within R mode, but not when within Markdown mode. (This seems like the most natural behaviour to me)