added early stopping to Jenkins scripts #5205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmcphers
approved these changes
Aug 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I was looking at your Jenkins setup today to see if there was anything interesting I could learn for my own projects. While doing that, I noticed that several of the scripts in
docker/do not useset -eto ensure early stopping if something breaks.In this PR, I propose that they should. Since these scripts contain imperative code that has side effects (e.g. hitting S3 with
aws s3 cp), I think it would be valuable to know they'll immediately stop if anything goes wrong.I've also removed a few unnecessary empty lines at the end of these files. If you prefer that I revert those whitespace-only changes please let me know and I'd be happy to.
Thanks in advance for your time and consideration!