Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix editor find / replace bar keyboard tab sequence #6217

Merged
merged 2 commits into from Feb 12, 2020
Merged

Fix editor find / replace bar keyboard tab sequence #6217

merged 2 commits into from Feb 12, 2020

Commits on Feb 12, 2020

  1. fix keyboard focus tab sequence in editor Find/Replace bar 

    - remove setting tab indexes > 0 on controls (this should never be done)
- don't set buttons to tab index -1; they are now able to show keyboard focus, not all of them have equivalent keyboard shortcuts, and those shortcuts are not discoverable to a keyboard/screen reader user without letting focus get to the buttons
    @gtritchie
    gtritchie committed Feb 12, 2020
    Configuration menu
    Copy the full SHA
    a4351ef View commit details
    Browse the repository at this point in the history

  2. add toolbar to replace-all button to disambiguate generic "All" label

    @gtritchie
    gtritchie committed Feb 12, 2020
    Configuration menu
    Copy the full SHA
    b3e0170 View commit details
    Browse the repository at this point in the history