Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop nulls in connection history db #6339

Merged
merged 1 commit into from Feb 27, 2020

Conversation

kevinushey
Copy link
Contributor

Band-aid for #6336.

Given that we don't have a reproducible example and (AFAIK) I'm the only one who's hit the problem, it may be better to take this for v1.4.

Copy link
Member

@jmcphers jmcphers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but let's merge to 1.4 since we have no reports of this in the wild.

@kevinushey kevinushey changed the base branch from master to v1.4 February 27, 2020 19:21
@kevinushey kevinushey force-pushed the bugfix/connections-history-drop-null branch from cc6e147 to 1a8f48a Compare February 27, 2020 19:23
@kevinushey kevinushey force-pushed the bugfix/connections-history-drop-null branch from 1a8f48a to 5412569 Compare February 27, 2020 19:24
@kevinushey kevinushey merged commit ad90ca4 into v1.4 Feb 27, 2020
@valerie-rstudio valerie-rstudio deleted the bugfix/connections-history-drop-null branch January 21, 2022 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants