Triggered reconnect on 3000 WebSocket error #13
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcheng5
approved these changes
Jun 28, 2018
|
Thanks, good call! Sorry for the inconvenience, but to accept contributions to RStudio packages, we require a signed individual or corporate contributor agreement as appropriate. You can send the signed copy to jj@rstudio.com. (Once you've signed, you're good across all RStudio repos) |
|
Yikes, this is still open. We can do without the CLA for such a simple change, but the dist/ files have changed a lot more than they should have--we should rebuild ourselves. |
aronatkins
added a commit
that referenced
this pull request
Mar 23, 2021
from #13 reapplying and rebuilding artifacts
|
Replaced by #25. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When connection is lost and resumed, the client can receive a c[3000,"No response from heartbeat"] message. This causes the client to disconnect. This commit treats the 3000 error as a recoverable error, and try to reconnect.
This issue is triggered in Google Chrome, which doesn't send pings to check if connection is healthy. Safari and Firefox notice a dropped connection before this situation occurs.