Merge pull request #1449 from rstudio/barbara/bugfix/insert-ui

Fix #1438: `unbindAll()` should not be called when inserting content with `insertUI()`
rstudio · Dec 1, 2016 · fc7f454 · fc7f454
2 parents dad401a + ef35fc6
commit fc7f454
Show file tree

Hide file tree

Showing 6 changed files with 14 additions and 4 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -9,6 +9,8 @@ shiny 0.14.2.9000
 
 ### Bug fixes
 
+* Fix [#1438](https://github.com/rstudio/shiny/issue/1438): `unbindAll()` should not be called when inserting content with `insertUI()` ([#1449](https://github.com/rstudio/shiny/pull/1449))
+
 * Fixed bug causing `<meta>` tags associated with HTML dependencies of Shiny R Markdown files to be rendered incorrectly. ([#1463](https://github.com/rstudio/shiny/pull/1463))
 
 

diff --git a/inst/www/shared/shiny.js b/inst/www/shared/shiny.js
diff --git a/inst/www/shared/shiny.js.map b/inst/www/shared/shiny.js.map
diff --git a/inst/www/shared/shiny.min.js b/inst/www/shared/shiny.min.js
diff --git a/inst/www/shared/shiny.min.js.map b/inst/www/shared/shiny.min.js.map
diff --git a/srcjs/output_binding_html.js b/srcjs/output_binding_html.js
@@ -25,6 +25,10 @@ var renderDependencies = exports.renderDependencies = function(dependencies) {
 // inputs/outputs. `content` can be null, a string, or an object with
 // properties 'html' and 'deps'.
 exports.renderContent = function(el, content, where="replace") {
+  if (where === "replace") {
+    exports.unbindAll(el);
+  }
+
   exports.unbindAll(el);
 
   var html;