Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shinyApp options argument ignored when passed to runApp #1359

Closed
burgerga opened this issue Sep 2, 2016 · 2 comments
Closed

shinyApp options argument ignored when passed to runApp #1359

burgerga opened this issue Sep 2, 2016 · 2 comments
Assignees

Comments

@burgerga
Copy link

burgerga commented Sep 2, 2016

In the below example the app is not opened in the external browser, maybe this can be made clear in the documentation for shinyApp, or (preferable IMO, but more work) let runApp read the options from the app if an app object is passed.

app <- shinyApp(
  ui = fluidPage(
    numericInput("n", "n", 1),
    plotOutput("plot")
  ),
  server = function(input, output) {
    output$plot <- renderPlot( plot(head(cars, input$n)) )
  },
  options = list(display.mode="showcase", launch.browser=T)
)
runApp(app)
@burgerga burgerga changed the title shinyApp options argument ignored when passed to runApp shinyApp options argument ignored when passed to runApp Sep 2, 2016
@burgerga
Copy link
Author

burgerga commented Sep 2, 2016

alternative is telling people to run it like app (print mode)

@wch wch added P2 labels Sep 19, 2016
@jcheng5
Copy link
Member

jcheng5 commented Nov 17, 2016

Note to implementer:

  1. Don't forget to check if runApp has explicit arguments, these should override options in the shinyApp object
  2. If this ends up being complicated/risky, punt to v.next

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants