Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File extension and fileInput #1501

Closed
carlganz opened this issue Dec 12, 2016 · 1 comment
Closed

File extension and fileInput #1501

carlganz opened this issue Dec 12, 2016 · 1 comment
Assignees
@alandipert @bborgesr

Comments

@carlganz
Copy link
Contributor

carlganz commented Dec 12, 2016 •
edited by bborgesr

Related to the issue here: tidyverse/readxl#85

The temporary files uploaded by fileInput have no file extension so some R functions (in particular readxl::read_excel) for reading in the file won't work. Currently people can work around this by changing the name of the file in the temp directory, but that seems inelegant.

Is there a good reason for not including the file extension of the original file?
@carlganz carlganz mentioned this issue Dec 12, 2016
Closed
@jcheng5
Copy link
Member

jcheng5 commented Jan 24, 2017

Let's also consider preserving the entire filename--there are cases like with shapefiles where the filenames matter.

@jennybc jennybc mentioned this issue Apr 17, 2017
Closed
@bborgesr bborgesr assigned alandipert and unassigned alandipert May 11, 2017
alandipert added a commit that referenced this issue May 16, 2017
@alandipert
fileInput: Attempt to use the name of the uploaded file as the temp f…
bc607cf 
…ile's basename on the

server.
- Fixes #1501
- Similar approach to #1502 but doesn't necessarily use file name
  verbatim, for security reasons.
alandipert added a commit that referenced this issue May 16, 2017
@alandipert
fileInput: Try to use the uploaded file name as basename on the server.
7ff0384 
- Fixes #1501
- Similar approach to #1502 but doesn't necessarily use file name
  verbatim for security reasons.
@alandipert alandipert mentioned this issue May 16, 2017
Merged
@wch wch closed this as completed in #1706 May 26, 2017
@wch wch removed the review label May 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alandipert alandipert

@bborgesr bborgesr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@alandipert @wch @jcheng5 @bborgesr @carlganz