Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use fastmap::faststack() and remove Stack class #3176

Merged
merged 4 commits into from
Feb 9, 2021
Merged

Use fastmap::faststack() and remove Stack class #3176

merged 4 commits into from
Feb 9, 2021

Conversation

wch
Copy link
Collaborator

@wch wch commented Dec 3, 2020 •
edited
Loading

This PR replaces the internal Stack class with fastmap::faststack(), and uses fastqueue() in places where it makes sense (we previously did direct list manipulation).

@wch wch requested a review from schloerke January 26, 2021 18:58
schloerke
schloerke reviewed Feb 9, 2021
View reviewed changes
R/bookmark-state.R Outdated Show resolved Hide resolved
schloerke
schloerke approved these changes Feb 9, 2021
View reviewed changes
Copy link
Collaborator

@schloerke schloerke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending question

@wch wch merged commit a634734 into master Feb 9, 2021
@wch wch deleted the wch-faststack branch February 9, 2021 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schloerke schloerke schloerke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wch @schloerke