Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly set width on textarea input element #3838

Merged
merged 4 commits into from Jun 12, 2023
Merged

Correctly set width on textarea input element #3838

merged 4 commits into from Jun 12, 2023

Conversation

gadenbuie
Copy link
Member

@gadenbuie gadenbuie commented Jun 12, 2023 •
edited

Fixes #3833

As pointed out in #3833, setting width in textAreaInput() resulted in the <textarea> element having style="width:width: 100%;;". We were using css() but accidentally repeating the property name.

Before this PR

textAreaInput('new','NULL', width='100%')
#> <div class="form-group shiny-input-container" style="width: 100%;">
#>   <label class="control-label" id="new-label" for="new">NULL</label>
#>  <textarea id="new" class="form-control" style="width:width: 100%;;"></textarea>
#> </div>

After this PR

textAreaInput('new', 'LABEL', width='100%')
#> <div class="form-group shiny-input-container" style="width: 100%;">
#>  <label class="control-label" id="new-label" for="new">LABEL</label>
#>   <textarea id="new" class="form-control" style="width:100%;"></textarea>
#> </div>

@gadenbuie gadenbuie mentioned this pull request Jun 12, 2023
Closed
@gadenbuie gadenbuie requested a review from wch June 12, 2023 16:15
@gadenbuie gadenbuie merged commit 2b48aa0 into main Jun 12, 2023
12 checks passed
@gadenbuie gadenbuie deleted the fix/3833-textAreaInput-width branch June 12, 2023 19:57
schloerke added a commit that referenced this pull request Jul 7, 2023
@schloerke
Merge branch 'main' into rc-v1.7.4.1
518ef0f 
* main: (55 commits)
  Catch errors receiving individual input messages (#3843)
  Clarify what's ignored by ignoreNULL (#3827)
  Remove tests/testthat/apps/ (#3841)
  Correctly set width on `textarea` input element (#3838)
  Update selectize.js documentation URLs (#3836)
  test(json digits): Try unsetting option in test to get default behavior (#3837)
  Rebuild docs
  Update README.md
  fix typo in the docs for bindCache (#3825)
  Allow for `shiny:::toJSON()` to respect if `digits` has class `AsIs` to represent `use_signif=` (#3819)
  More complete `downloadButton()` example
  Rename actionQueue to taskQueue, add more context to the NEWS item (#3801)
  Remove unneeded packages from package.json
  Rebuild docs
  Rebuild shiny.js
  Update @types/node
  Rebuild yarn.lock
  Fix brush resetting behavior. Closes #3785
  Bump fastmap dependency to 1.1.1
  Sync package version (GitHub Actions)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wch wch wch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

specifying textArea width leads to mangled style attribute in output
2 participants
@gadenbuie @wch