Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for shiny:::toJSON() to respect if digits has class AsIs to represent use_signif= #3819

Merged
merged 2 commits into from
May 16, 2023

Conversation

schloerke
Copy link
Collaborator

If digits is of type AsIs, then use_signif = TRUE

Related: jeroen/jsonlite@728efa9

If `digits` is of type `AsIs`, then `use_signif = TRUE`
@schloerke schloerke requested a review from wch May 8, 2023 19:22
@schloerke schloerke marked this pull request as ready for review May 8, 2023 19:22
@schloerke schloerke merged commit 90539bf into main May 16, 2023
@schloerke schloerke deleted the json_signif_digits branch May 16, 2023 20:14
schloerke added a commit that referenced this pull request Jul 7, 2023
* main: (55 commits)
  Catch errors receiving individual input messages (#3843)
  Clarify what's ignored by ignoreNULL (#3827)
  Remove tests/testthat/apps/ (#3841)
  Correctly set width on `textarea` input element (#3838)
  Update selectize.js documentation URLs (#3836)
  test(json digits): Try unsetting option in test to get default behavior (#3837)
  Rebuild docs
  Update README.md
  fix typo in the docs for bindCache (#3825)
  Allow for `shiny:::toJSON()` to respect if `digits` has class `AsIs` to represent `use_signif=` (#3819)
  More complete `downloadButton()` example
  Rename actionQueue to taskQueue, add more context to the NEWS item (#3801)
  Remove unneeded packages from package.json
  Rebuild docs
  Rebuild shiny.js
  Update @types/node
  Rebuild yarn.lock
  Fix brush resetting behavior. Closes #3785
  Bump fastmap dependency to 1.1.1
  Sync package version (GitHub Actions)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants