Catch errors receiving individual input messages #3843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
wch
approved these changes
Jun 30, 2023
schloerke
added a commit
that referenced
this pull request
Jul 7, 2023
* main: (55 commits) Catch errors receiving individual input messages (#3843) Clarify what's ignored by ignoreNULL (#3827) Remove tests/testthat/apps/ (#3841) Correctly set width on `textarea` input element (#3838) Update selectize.js documentation URLs (#3836) test(json digits): Try unsetting option in test to get default behavior (#3837) Rebuild docs Update README.md fix typo in the docs for bindCache (#3825) Allow for `shiny:::toJSON()` to respect if `digits` has class `AsIs` to represent `use_signif=` (#3819) More complete `downloadButton()` example Rename actionQueue to taskQueue, add more context to the NEWS item (#3801) Remove unneeded packages from package.json Rebuild docs Rebuild shiny.js Update @types/node Rebuild yarn.lock Fix brush resetting behavior. Closes #3785 Bump fastmap dependency to 1.1.1 Sync package version (GitHub Actions) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3840 by catching errors when calling
inputBinding.receiveMessage()on individual messages in theinputMessageshandler.It turns out that wrapping the message handler call itself in
_sendMessagesToHandlers(), as proposed here, wasn't quite low enough: the messages are processed at once by each handler so if one input message failed, all subsequent input messages in the same cycle would fail as well.While here, I also updated the error message in the
SliderInputBindingwhen a zero-length value is received.TODO
valueinupdateSliderInput()?