Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.7.4.1 release candidate #3850

Merged
merged 2 commits into from Jul 7, 2023
Merged

1.7.4.1 release candidate #3850

merged 2 commits into from Jul 7, 2023

Conversation

wch
Copy link
Collaborator

@wch wch commented Jun 30, 2023

This fixes an issue that CRAN asked us to fix ASAP. Closes #3849.

@wch wch requested a review from schloerke June 30, 2023 19:07
@CLAassistant
Copy link

CLAassistant commented Jun 30, 2023

CLA assistant check
All committers have signed the CLA.

Remove use of as.numeric_version()
Closes #3849
* main: (55 commits)
  Catch errors receiving individual input messages (#3843)
  Clarify what's ignored by ignoreNULL (#3827)
  Remove tests/testthat/apps/ (#3841)
  Correctly set width on `textarea` input element (#3838)
  Update selectize.js documentation URLs (#3836)
  test(json digits): Try unsetting option in test to get default behavior (#3837)
  Rebuild docs
  Update README.md
  fix typo in the docs for bindCache (#3825)
  Allow for `shiny:::toJSON()` to respect if `digits` has class `AsIs` to represent `use_signif=` (#3819)
  More complete `downloadButton()` example
  Rename actionQueue to taskQueue, add more context to the NEWS item (#3801)
  Remove unneeded packages from package.json
  Rebuild docs
  Rebuild shiny.js
  Update @types/node
  Rebuild yarn.lock
  Fix brush resetting behavior. Closes #3785
  Bump fastmap dependency to 1.1.1
  Sync package version (GitHub Actions)
  ...
@schloerke
Copy link
Collaborator

The "GHA push routine" checks are a false positive. The true check was done for f5b3954 above. This commit was tagged and the PR needs to have a "merge" commit. After merging, the "merge" checks pass.

Merging PR

@schloerke schloerke merged commit f724128 into main Jul 7, 2023
22 of 23 checks passed
@schloerke schloerke deleted the rc-v1.7.4.1 branch July 7, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

R-devel raises warnings on package load, because of as.numeric_version()
3 participants