Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

head deduplication should not be line-oriented #4

Closed
jcheng5 opened this issue Jul 27, 2012 · 1 comment
Closed

head deduplication should not be line-oriented #4

jcheng5 opened this issue Jul 27, 2012 · 1 comment
Assignees
@jjallaire

Comments

@jcheng5
Copy link
Member

jcheng5 commented Jul 27, 2012 •
edited by bborgesr

Line-oriented deduplication can cause JavaScript code to be mangled, for example:

head(tags$script("
if (location.hash) {
  console.log(location.hash);
}
else {
  console.log('No hash');
}
"))

In this example, the latter close-brace will be stripped because an identical line appeared earlier.

We probably need a solution that operates on the direct-child level.
@ghost ghost assigned jjallaire Jul 27, 2012
jcheng5 added a commit that referenced this issue Aug 18, 2012
@jcheng5
Improvements to reactives and UI
d49e8d1 
- `input` object now implements names() and as.list()
- Simpler dependency tracking impl using Dependencies class
- New `singleton` function for making HTML content appear only once
- Fix issue #4: head deduplication should not be line-oriented
@jcheng5
Copy link
Member Author

jcheng5 commented Aug 18, 2012

Fixed in d49e8d1

@jcheng5 jcheng5 closed this as completed Aug 18, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jjallaire jjallaire

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jjallaire @jcheng5