Enable plot replaying #1112
Merged
Enable plot replaying #1112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should be good to go now. |
| } | ||
|
|
||
|
|
||
| render <- reactive({ |
There was a problem hiding this comment.
Nit: I don't like verbs as names of reactive expressions. render() looks like it's a directive to render the plot, when the whole point of it is to not be that. A noun would be better.
|
I've made the changes to address the feedback: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a plot is made in
renderPlot, it records the display list withrecordPlot. Later, if only the height or width has changed (and no other inputs), the plot can be replayed withreplayPlot, which can give a speed boost, especially with ggplot2.