Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use randomly-chosen port numbers that Chrome deems unsafe #1222

Merged
merged 1 commit into from Jul 20, 2016
Merged

Don't use randomly-chosen port numbers that Chrome deems unsafe #1222

merged 1 commit into from Jul 20, 2016

Conversation

jcheng5
Copy link
Member

@jcheng5 jcheng5 commented Jun 26, 2016 •
edited by bborgesr

Still OK to use these ports if the user asks for them explicitly

Chrome actually blocks these URLs from loading.

image

@jcheng5
Don't use randomly-chosen port numbers that Chrome deems unsafe
8b3aff5 
Still OK to use these ports if the user asks for them explicitly
@jcheng5
Copy link
Member Author

jcheng5 commented Jul 20, 2016

@wch @bborgesr Any concerns, or can we merge?

@wch
Copy link
Collaborator

wch commented Jul 20, 2016

LGTM

@jcheng5
Copy link
Member Author

jcheng5 commented Jul 20, 2016

One of the few places a do-while loop would've been nice I guess

@jcheng5 jcheng5 merged commit f701875 into master Jul 20, 2016
@bborgesr bborgesr mentioned this pull request Jul 27, 2016
Closed
@bborgesr bborgesr deleted the joe/bugfix/chrome-unsafe-ports branch September 2, 2016 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jcheng5 @wch