Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ... arg to downloadButton #1492

Merged
merged 1 commit into from
Dec 5, 2016
Merged

Add ... arg to downloadButton #1492

merged 1 commit into from
Dec 5, 2016

Conversation

bborgesr
Copy link
Contributor

@bborgesr bborgesr commented Dec 2, 2016

Added ability to pass arguments to the a tag function called inside downloadButton() and downloadLink(). Closes #986.

After seeing this referenced in another issue, this seemed like a very reasonable request that is not hard or risky to implement and doesn't break backward compatibility. Do you agree @wch, @jcheng5 ?

Demo app:

ui <- fluidPage( downloadButton("download", style = "background-color:#C9DD03"))
server <- function(input, output, session) {}
shinyApp(ui, server)

@bborgesr bborgesr added the review label Dec 2, 2016
… `downloadButton()` and `downloadLink()`. Closes #986.
@bborgesr bborgesr merged commit 2e1c371 into master Dec 5, 2016
@bborgesr bborgesr deleted the barbara/download-args branch December 5, 2016 15:37
@bborgesr bborgesr removed the review label Dec 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant