Fix progress bar #1547
Merged
Fix progress bar #1547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also removes the documentation which said that using NULL would cause the progress bar to be hidden.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1472. Calling
progress$set()with a NULLvalueno longer makes the progress bar go to 100%.The documentation also said that setting the
valuetoNULLwould hide the progress status. It looks like we had code that tried to do that, but didn't actually work. I didn't see why it would be desirable to hide the progress bar anyway, since you can simply callprogress$close()to remove it. So I fixed the documentation and removed the bits of code that tried to hide the progress status.