Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decode URLs in staticHandler func (fixes #1565) #1566

Merged
merged 2 commits into from Feb 1, 2017
Merged

Conversation

bborgesr
Copy link
Contributor

@bborgesr bborgesr commented Jan 31, 2017

@jcheng5 is it this simple to fix the URL problem in #1565? I tested the example app and all three ways work now:

library(shiny)

addResourcePath("foo", "foo")

ui <- fluidPage(
  img(src="foo/foo.png"),
  img(src="foo/b a r.png"),
  img(src=URLencode("foo/b a r.png")),
  img(src="foo/b a r.png")
)

shinyApp(ui = ui, server = function(input, output) {})

given that these is a foo folder with a foo.png image and a b a r.png image.

@bborgesr
Copy link
Contributor Author

Just because it's fun...

Before:
screen shot 2017-01-31 at 1 08 25 am

After:
screen shot 2017-01-31 at 1 07 38 am

@wch
Copy link
Collaborator

wch commented Jan 31, 2017

LGTM. NEWS item?

@bborgesr bborgesr merged commit 220c7e9 into master Feb 1, 2017
@bborgesr bborgesr removed the review label Feb 1, 2017
@bborgesr bborgesr deleted the barbara/urldecode branch February 1, 2017 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants