New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert examples to single file apps #1685
Conversation
- Make relevant updates to Readmes to match up with app.R structure - Add color to plots (RStudio blue) - In 04_mpg example: Show outliers by default, as opposed to hide, since this is more routine - In 06_tabsets and 08_html examples: Don't name random data vector "data" - Add extensive comments to app.R files and use consistent formatting of comments across examples - In 09_upload example: Use req() to check for NULL entry
@mine-cetinkaya-rundel, I skimmed through this and it looks great; I trust that you were able to run each example with no problems, right? |
Thanks, and yes I was able to run each one. |
I'm tempted to replace all the |
@jcheng5 One could use arbitrary names for the |
Alternatively leave as is for first couple examples, then shorten? |
…11, except for the custom HTML example. Kept them in for examples 1&2 for completeness in first exporuse to function.
Implemented @jcheng5's suggestion for examples 3-11 except for custom HTML example |
app.R
file04_mpg
: Show outliers by default, as opposed to hide, since this is more routine, usepch = 19
for outlier so it's more easily visible06_tabsets
and08_html
: Don't name random data vectordata
(named
instead)08_html
: Add headers to clarify what each output is and show only head of data to simplify app09_upload
: Usereq()
to check for NULL entry, update comments to reflect single file upload, show only head of uploaded file by default, with an option to view all if requested10_download
:row.names = FALSE
inwrite.csv()