Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

relay offsetWidth/offsetHeight of htmlwidgets to clientData #1981

Merged
merged 5 commits into from Mar 20, 2018
Merged

relay offsetWidth/offsetHeight of htmlwidgets to clientData #1981

merged 5 commits into from Mar 20, 2018

Conversation

cpsievert
Copy link
Collaborator

Adresses #1980

cpsievert added a commit to cpsievert/htmlwidgets that referenced this pull request Mar 20, 2018
@cpsievert
add reportSize param to shinyWidgetOutput(), based on rstudio/shiny#1981
732a19b
@cpsievert
Copy link
Collaborator Author

How about adding a parameter to the htmlwidgets::shinyWidgetOutput function, e.g. reportSize = FALSE, which then adds the shiny-report-size class for you?

Sounds good!

cpsievert added a commit to cpsievert/htmlwidgets that referenced this pull request Mar 20, 2018
@cpsievert
add reportSize param to shinyWidgetOutput(), based on rstudio/shiny#1981
b7891ce
@cpsievert cpsievert mentioned this pull request Mar 20, 2018
Merged
jcheng5 pushed a commit to ramnathv/htmlwidgets that referenced this pull request Mar 20, 2018
@cpsievert @jcheng5
add reportSize param to shinyWidgetOutput(), based on rstudio/shiny#1981
201ef8a 
 (#303)
@jcheng5
Copy link
Member

jcheng5 commented Mar 20, 2018

Thanks, two more things, thanks for your patience.

  1. Add NEWS.md item

  2. Ensure that you have signed the individual or corporate contributor agreement as appropriate. You can send the signed copy to jj@rstudio.com. (Once you've signed, you're good across all RStudio repos)

@cpsievert
Copy link
Collaborator Author

Just realized values weren't being invalidated on resize, 44746e9 should fix that

@cpsievert
Copy link
Collaborator Author

@jcheng5 should be good to go now

@jcheng5 jcheng5 merged commit 0555cbd into rstudio:master Mar 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cpsievert @jcheng5