Trigger shiny:value even if same data is received #1999
Conversation
| $(binding ? binding.el : document).trigger(evt); | ||
| return undefined; | ||
| } | ||
|
|
There was a problem hiding this comment.
The order is incorrect; the event shouldn't be triggered until after this.$values[name] = value; and delete this.$errors[name];. If for no other reason, errors in the trigger shouldn't stop those side effects.
There was a problem hiding this comment.
There are two cases, as in the version without the PR: a) client receives the same value as before, b) client receives a new value.
In case a) there is no need to assign the value (this should be more efficient as the DOM doesn't need to be updated) and there should be no errors to delete. This is the same behaviour as before, the only change here is that the event is now triggered (the event parameters need to be set up before).
There was a problem hiding this comment.
Sorry, this looks good. I don't know what I was thinking. 😅
| $(binding ? binding.el : document).trigger(evt); | ||
|
|
There was a problem hiding this comment.
Triggered a second time? (Maybe I'm missing something)
There was a problem hiding this comment.
This is case b) when the value actually needs to be updated. The event needs to be triggered in this case as well.
|
Thanks for your patience. One last thing: to accept contributions to RStudio packages, we need a signed the individual or corporate contributor agreement as appropriate. You can send the signed copy to jj@rstudio.com. (Once you've signed, you're good across all RStudio repos) Thanks for the contribution! |
|
Thanks @jcheng5 , I have sent now the contributor agreement. |
|
Hi @jcheng5, is there anything holding back this PR? |
|
@andrewsali No, it's going in this week, probably today |
|
OK, thanks, that's much appreciated |
This PR fixes #1978 . Without this PR, if the client receives the same data from the server, no
shiny:valueis triggered. On the other hand the client sees that the value was invalidated previously (shiny:outputinvalidatedis triggered), but unfortunately doesn't know when the old value is confirmed to be still valid.The role of this PR is to bring back the symmetry: if
shiny:outputinvalidatedis triggered on an element, then eventually ashiny:value(orshiny:error) should also be triggered.