Fix dragging and dropping in the presence of jQuery 3.0 #2005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcheng5
approved these changes
Apr 10, 2018
|
@jcheng5 I updated NEWS and called this a bug fix, but later realized it might be considered an improvement/enhancement. What do you think? |
|
I don't have a preference |
|
Closes #1962 |
|
@jcheng5 approved and @shalutiwari completed QA, so merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drag and drop relied on jQuery's .size() method, which was deprecated in jQuery 1.8 and removed in 3.0.
The method works in Shiny's version of jQuery, 1.12.4. However, the feature breaks when htmlwidgets introduce jQuery >= 3.0, as happened in #1962.
This fix uses
.lengthinstead of.sizeand should make DnD more resilient in the presence of newer versions of jQuery.