Fix #2021: Memory leak with reactiveTimer and invalidateLater #2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schloerke
approved these changes
Apr 19, 2018
| .funcs$remove(toRemoveId) | ||
| } | ||
| } | ||
| return(id %in% toRemoveIds) |
There was a problem hiding this comment.
This matches the prior if statement. Maybe a explicit return(TRUE) inside line 53 and return(FALSE) otherwise?
There was a problem hiding this comment.
It's a vectorized result, so you can see which of the id's you passed in were actually found and removed.
There was a problem hiding this comment.
Sorry, I guess I didn't make this explicit: you can pass in a vector multiple id's.
jcheng5
force-pushed
the
joe/bugfix/timer-leak
branch
from
becab18
to
31c4e0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reactiveTimerandinvalidateLaterhad mechanisms to ensure they wouldn't have any effect once their owning sessions ended. But they didn't have anything in place to ensure that their closures could be garbage collected. This is because the underlying TimerCallbacks class I implemented way way back in the day, did not provide any way to truly unregister something that was scheduled for execution. This PR corrects that oversight and modifiesreactiveTimerandinvalidateLaterto take advantage of that.Testing notes
See #2021 for repro apps.