Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

freeze/thaw reactiveValues with namespace support #2080

Merged
merged 6 commits into from Jun 29, 2018

Conversation

schloerke
Copy link
Collaborator

The current definition of $.reactivevalues adds a namespace to the key. When freezing, the same namespaced-key needs to be frozen and thawed.

Current value of $.reactivevalues

`$.reactivevalues` <- function(x, name) {
  checkName(name)
  .subset2(x, 'impl')$get(.subset2(x, 'ns')(name))
}

@schloerke schloerke requested a review from jcheng5 June 29, 2018 15:35
@jcheng5 jcheng5 merged commit 81cc7c5 into rstudio:master Jun 29, 2018
@jcheng5 jcheng5 removed their request for review June 29, 2018 22:59
@schloerke schloerke deleted the barret-freeze-thaw branch September 10, 2018 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants