add domain to reactlog for context exit #2180
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2177
The domain being saved when the context was exiting is not properly saved when a top level context is exiting.
The errors received in #2177 were due to a
NULL
session token. When only looking at a single session, this was not an issue. When looking at the result of multiple sessions, either session would improperly capture the extra exits being generated in the global session space (when they are really session specific).Regular, single session exit tokens done in a session only. The default global domain token is not being captured properly, while the local
.domain$token
value is captured correctly.