Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update formatting settings #4065

Merged
merged 5 commits into from
May 24, 2024
Merged

Update formatting settings #4065

merged 5 commits into from
May 24, 2024

Conversation

wch
Copy link
Collaborator

@wch wch commented May 24, 2024

This PR makes the following changes:

  • Updates the VS Code settings to format .json files on save.
  • Adds prettier-plugin-organize-imports to sort JS/TS imports on save.

@wch wch requested a review from schloerke May 24, 2024 14:10
@@ -1,5 +1,5 @@
# Updates the package.json `version` to match the DESCRIPTION `Version`
pkg <- jsonlite::read_json("package.json", simplifyVector = TRUE)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The simplifyVector = TRUE here was causing the package.json file to be changed in a way that broke it.

@wch wch merged commit 3e0efd8 into main May 24, 2024
1 check passed
@wch wch deleted the format-settings branch May 24, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant