Assert target application server is the same type recording was created with #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alandipert
added
Priority: Medium
…n't parse properly
alandipert
commented
Jun 13, 2019
| xpath(resp.body, "/html/head/script") | ||
| .flatMap { List(it.attributes.length, { i -> it.attributes.item(i)}) } | ||
| .filter { it.nodeName == "src" } | ||
| .find { it.nodeValue.matches("^.*/shiny.min.js$".toRegex()) } |
There was a problem hiding this comment.
Need to escape dots and also check for shiny.js too
alandipert
commented
Jun 13, 2019
| fun readProps(lines: List<String>, logger: Logger): Props { | ||
| val props = lines.asSequence() | ||
| .takeWhile { it.startsWith("#") } | ||
| .map { readPropLine(it) } |
There was a problem hiding this comment.
Why doesn't .map(readPropLine) work?
alandipert
commented
Jun 13, 2019
| logger.warn("Recording made with '${rec.props.targetType.typeName}' but target looks like '${detectedType.typeName}'") | ||
| } | ||
|
|
||
| if (rec.props.version < RECORDING_VERSION) { |
There was a problem hiding this comment.
Don't need to warn because there won't necessarily be a problem
alandipert
commented
Jun 13, 2019
| .takeWhile { it.startsWith("#") } | ||
| .map { readPropLine(it) } | ||
| .toMap() | ||
| if (props.containsKey("target")) { |
There was a problem hiding this comment.
Need to accept old recordings, no need to warn
alandipert
added a commit
to rstudio/shinyloadtest
that referenced
this pull request
Jun 14, 2019
Corresponds to rstudio/shinycannon#36
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see rstudio/shinyloadtest#107 for details and discussion.