Use shiny-workflows (#379)

.github/workflows/R-CMD-check.yaml

@@ -1,70 +1,22 @@
-# Workflow derived from https://github.com/r-lib/actions/tree/master/examples
-# Need help debugging build failures? Start at https://github.com/r-lib/actions#where-to-find-help
+# Workflow derived from https://github.com/rstudio/shiny-workflows
 #
-# NOTE: This workflow is overkill for most R packages and
-# check-standard.yaml is likely a better choice.
-# usethis::use_github_action("check-standard") will install it.
+# NOTE: This Shiny team GHA workflow is overkill for most R packages.
+# For most R packages it is better to use https://github.com/r-lib/actions
 on:
   push:
-    branches: [main, master]
+    branches: [main, rc-**]
   pull_request:
-    branches: [main, master]
+    branches: [main]
+  schedule:
+    - cron:  '0 5 * * 1' # every monday
 
-name: R-CMD-check
+name: Package checks
 
 jobs:
+  ## Website must be updated manually
+  # website:
+  #  uses: rstudio/shiny-workflows/.github/workflows/website.yaml@v1
+  routine:
+    uses: rstudio/shiny-workflows/.github/workflows/routine.yaml@v1
   R-CMD-check:
-    runs-on: ${{ matrix.config.os }}
-
-    name: ${{ matrix.config.os }} (${{ matrix.config.r }})
-
-    strategy:
-      fail-fast: false
-      matrix:
-        config:
-          - {os: macOS-latest,   r: 'release'}
-
-          - {os: windows-latest, r: 'release'}
-          # Use 3.6 to trigger usage of RTools35
-          - {os: windows-latest, r: '3.6'}
-
-          # Use older ubuntu to maximise backward compatibility
-          - {os: ubuntu-18.04,   r: 'devel', http-user-agent: 'release'}
-          - {os: ubuntu-18.04,   r: 'release'}
-          - {os: ubuntu-18.04,   r: 'oldrel-1'}
-          - {os: ubuntu-18.04,   r: 'oldrel-2'}
-          - {os: ubuntu-18.04,   r: 'oldrel-3'}
-          - {os: ubuntu-18.04,   r: 'oldrel-4'}
-
-    env:
-      GITHUB_PAT: ${{ secrets.GITHUB_TOKEN }}
-      R_KEEP_PKG_SOURCE: yes
-
-    steps:
-      - uses: actions/checkout@v2
-
-      - uses: r-lib/actions/setup-pandoc@v1
-
-      - uses: r-lib/actions/setup-r@v1
-        with:
-          r-version: ${{ matrix.config.r }}
-          http-user-agent: ${{ matrix.config.http-user-agent }}
-          use-public-rspm: true
-
-      - uses: r-lib/actions/setup-r-dependencies@v1
-        with:
-          extra-packages: rcmdcheck
-
-      - uses: r-lib/actions/check-r-package@v1
-
-      - name: Show testthat output
-        if: always()
-        run: find check -name 'testthat.Rout*' -exec cat '{}' \; || true
-        shell: bash
-
-      - name: Upload check results
-        if: failure()
-        uses: actions/upload-artifact@main
-        with:
-          name: ${{ runner.os }}-r${{ matrix.config.r }}-results
-          path: check
+    uses: rstudio/shiny-workflows/.github/workflows/R-CMD-check.yaml@v1

DESCRIPTION

@@ -20,4 +20,5 @@ Imports:
     htmltools (>= 0.2.6),
     promises
 BugReports: https://github.com/rstudio/shinydashboard
-RoxygenNote: 6.0.1.9000
+RoxygenNote: 7.1.2
+Encoding: UTF-8

R/menuOutput.R

@@ -151,7 +151,7 @@ renderMenu <- function(expr, env = parent.frame(), quoted = FALSE, outputArgs =
 
 # R CMD check thinks that shiny::renderUI has an undeclared global variable
 # called "func".
-globalVariables("func")
+utils::globalVariables("func")
 
 #' Create a dropdown menu output (server side; deprecated)
 #'

R/shinydashboard-package.r

@@ -1,6 +1,3 @@
-#' shinydashboard
-#'
-#' @name shinydashboard
 #' @import htmltools
-#' @docType package
-NULL
+#' @keywords internal
+"_PACKAGE"

README.md

@@ -2,7 +2,7 @@ Shiny Dashboard
 ===============
 
 <!-- badges: start -->
-  [![R-CMD-check](https://github.com/rstudio/shinydashboard/workflows/R-CMD-check/badge.svg)](https://github.com/rstudio/shinydashboard/actions)
+  [![R-CMD-check](https://github.com/rstudio/shinydashboard/actions/workflows/R-CMD-check.yaml/badge.svg)](https://github.com/rstudio/shinydashboard/actions)
 <!-- badges: end -->
 
 ## Installation