Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump dplyr version and whitelist events to be plotted #68

Merged
merged 12 commits into from May 13, 2019
Merged

Bump dplyr version and whitelist events to be plotted #68

merged 12 commits into from May 13, 2019

Conversation

schloerke
Copy link
Collaborator

Posted dev dplyr issue: tidyverse/dplyr#4096

The goal of the code is to convert all run or label columns to character and then back convert them to factors after they have been filtered / mutated.

(Should be merged after #67 )

@romainfrancois
Copy link

Once this PR is merged to dplyr you'll only have to add the .drop = TRUE to group_by() calls instead of converting factors to character vectors.

tidyverse/dplyr#4091

@schloerke
use dplyr PR that fixes group_by bug
0d99567 
Depending on tidyverse/dplyr#4091 to be merged
@schloerke
use new .drop = TRUE argument for group_by and remove all `conver…
cacbde1 
…t_*` methods.
@schloerke
use ungroup and group(run = droplevels(run)) or similar where appropr…
c1f639f 
…iate

works with dplyr 0.7.8 and 0.8.0
@schloerke
Merge branch 'master' into dplyr_08
a0fecda 
* master:
  pkgdown::build_site()
  Add record/playback limitation (#76)
  Minor whitespace
  Support query string, improve open_browser behavior
  Simplify query string handling and add basic URLBuilder tests
  Added query handling so that you can use bookmarked links and rsc.
  partially working commit to fix the host for rstudio server pro environments.
  Added handling for url's with query's.
  add openssl installation notes in pkgdown index page
@schloerke
use cran dplyr >= v0.8.0.1 and not the remote
00dd11e
@schloerke
remove dplyr.R file
f2db557
@schloerke
white space
97ca572
@schloerke
undo unnecessary changes
1c27f41
@schloerke
Copy link
Collaborator Author

schloerke commented Apr 1, 2019 •
edited

  • Bumped the dplyr version. Bug is not visible anymore.
  • Filtering is done on events to "white list" vs "black list" the events, as new events may be added.
  • Added some ungroup calls to aid in logic. Not necessary, but nice to have.
  • Passing the original run levels where appropriate to have facet's be consistent. Removed this as it isn't needed anymore.

@schloerke schloerke requested review from wch and removed request for jcheng5 April 25, 2019 18:34
@wch wch merged commit 4d477eb into master May 13, 2019
@wch wch changed the title add helper methods to work around dev dplyr bug Bump dplyr version and whitelist events to be plotted May 13, 2019
@schloerke schloerke mentioned this pull request May 14, 2019
Closed
@alandipert alandipert deleted the dplyr_08 branch May 15, 2019 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wch wch Awaiting requested review from wch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@schloerke @romainfrancois @wch