Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove trailing comma in app.R #239

Merged
merged 4 commits into from Aug 19, 2022
Merged

Remove trailing comma in app.R #239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6a15fb9
Remove trailing comma
schloerke Jul 22, 2022
e1db822
Update NEWS.md
schloerke Jul 22, 2022
7b2e628
`devtools::document()` (GitHub Actions)
schloerke Jul 22, 2022
42cf65e
Merge branch 'main' into record_app_trailing_comma
schloerke Aug 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions NEWS.md
View file
Open in desktop
Expand Up @@ -18,6 +18,8 @@

* When testing and `{chromote}` can not be started, the test will be skipped. When testing on windows in CI, `{chromote}` will get an attempt to be started (#225)

* Remove trailing comma causing render bug in recorder app (@mehrnoushmalek, #239)

* Update {lintr} lints to v3 (#240)

# shinytest2 0.1.0
Expand Down
2 changes: 1 addition & 1 deletion inst/internal/recorder/app.R
View file
Open in desktop
Expand Up @@ -345,7 +345,7 @@ shinyApp(
textInput("testname", label = "Test name:", value = app_name),
class = "inline-input-container",
),
tooltip("The name of the test should be short, unique, and path-friendly way to describe what the set of expectations are trying to confirm."),
tooltip("The name of the test should be short, unique, and path-friendly way to describe what the set of expectations are trying to confirm.")
),
tagAppendChild(
tagAppendAttributes(
Expand Down