-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tbl_grade_*()
functions pass ellipsis to gradethis::fail()
#68
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In tbl_grade()
, instead of
#' @param ... Additional arguments passed to [gradethis::fail()].
can we instead @inheritDotParams gradethis::fail
?
TIL a new roxygen tag. Updated in 4a0d279. |
I'm not sure where I learned about it, it's not mentioned in
I found that piece of knowledge in the roxygen2 news: https://github.com/r-lib/roxygen2/blob/7b706c9f7f2e4227c98928a67c5dcb51d88ec15d/NEWS.md#improved-inheritance. (TIL that This is also probably a good time to mention that you can re-use roxygen snippets. Create an #' @template describe-meta-return |
@gadenbuie I regenerated the documentation with |
I'm not sure, I just mentioned it because, once you set it up, you wouldn't need to modify 10ish files to adjust it. |
tbl_grade_*()
functions gain the argument...
...
is passed totbl_grade()
tbl_grade()
passes...
togradethis::fail()
(pre-existing behavior)Closes #67.