Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix argument injection in feature_columns() #177

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lionel-
Copy link

@lionel- lionel- commented Sep 18, 2019

  • Remove use of deprecated quo_expr(). It was renamed in rlang 0.2.0 to quo_squash() to make it clear that it's not a quosure accessor. Instead, it recursively unwraps all quosures in the expression tree. It seems the quosure accessor quo_get_expr() is the intended function here.

  • Replace unsafe use of node_car() and node_cdr() with a small util call_inject_args(). Taking the CAR or CDR on something else than calls will crash R, and the arguments were not type checked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant