Fix argument injection in feature_columns()
#177
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove use of deprecated
quo_expr()
. It was renamed in rlang 0.2.0 toquo_squash()
to make it clear that it's not a quosure accessor. Instead, it recursively unwraps all quosures in the expression tree. It seems the quosure accessorquo_get_expr()
is the intended function here.Replace unsafe use of
node_car()
andnode_cdr()
with a small utilcall_inject_args()
. Taking the CAR or CDR on something else than calls will crash R, and the arguments were not type checked.