Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DateRangePicker): fix predefined range and OK button conflict #2701

Merged
merged 3 commits into from
Sep 8, 2022

Conversation

simonguo
Copy link
Member

@simonguo simonguo commented Sep 8, 2022

fix: #2691

After

image

image

@vercel
Copy link

vercel bot commented Sep 8, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
rsuite-nextjs ✅ Ready (Inspect) Visit Preview Sep 8, 2022 at 9:53AM (UTC)
1 Ignored Deployment
Name Status Preview Updated
rsuite-v4 ⬜️ Ignored (Inspect) Sep 8, 2022 at 9:53AM (UTC)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 8, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b579e1f:

Sandbox Source
rsuite-tp-ci Configuration

@codecov
Copy link

codecov bot commented Sep 8, 2022

Codecov Report

Merging #2701 (b579e1f) into main (dd0fc48) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2701      +/-   ##
==========================================
- Coverage   85.50%   85.48%   -0.03%     
==========================================
  Files         295      295              
  Lines        9112     9112              
  Branches     2571     2572       +1     
==========================================
- Hits         7791     7789       -2     
- Misses        694      696       +2     
  Partials      627      627              
Flag Coverage Δ
ChromeCi 85.48% <ø> (-0.03%) ⬇️
Firefox 85.45% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/DatePicker/Toolbar.tsx 100.00% <ø> (ø)
src/List/helper/useSortHelper.ts 77.95% <0.00%> (-1.42%) ⬇️
src/Uploader/UploadTrigger.tsx 72.54% <0.00%> (-0.53%) ⬇️
src/Uploader/Uploader.tsx 74.65% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@SevenOutman SevenOutman merged commit e538d57 into main Sep 8, 2022
@SevenOutman SevenOutman deleted the fix/date-range-picker branch September 8, 2022 09:57
myNameIsDu pushed a commit to myNameIsDu/rsuite that referenced this pull request Oct 12, 2022
…uite#2701)

* fix(DateRangePicker): fix predefined range and OK button conflict

* fix(Toolbar): use wrap on PredefinedRanges

* test(Toolbar): add tests for PredefinedRanges
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DateRangePicker with prop showOneCalendar has broken OK button
2 participants