Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Form): fix nestedField will auto trigger validation for other sibling fields #3741

Merged
merged 6 commits into from
Apr 19, 2024

Conversation

simonguo
Copy link
Member

fix: #3722

Copy link

codesandbox bot commented Apr 15, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

vercel bot commented Apr 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rsuite-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2024 11:29am
rsuite-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2024 11:29am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
rsuite-v4 ⬜️ Ignored (Inspect) Visit Preview Apr 18, 2024 11:29am

Copy link

codesandbox-ci bot commented Apr 15, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

codecov bot commented Apr 18, 2024

Codecov Report

Attention: Patch coverage is 94.50980% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 93.74%. Comparing base (2896530) to head (d27b60c).

Files Patch % Lines
src/Form/hooks/useFormValidate.ts 90.41% 0 Missing and 7 partials ⚠️
src/Form/Form.tsx 76.47% 4 Missing ⚠️
src/Form/hooks/useFormRef.ts 81.81% 1 Missing and 1 partial ⚠️
src/FormControl/hooks/useRegisterModel.ts 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3741   +/-   ##
=======================================
  Coverage   93.74%   93.74%           
=======================================
  Files         648      651    +3     
  Lines       22514    22540   +26     
  Branches     3076     3076           
=======================================
+ Hits        21105    21130   +25     
  Misses        722      722           
- Partials      687      688    +1     
Flag Coverage Δ
ChromeCi 93.70% <94.50%> (+<0.01%) ⬆️
Firefox 93.07% <92.94%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Form: nestedField will automatically trigger validation for other sibling field
1 participant