Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Fade): fix Picker not working in Drawer without backdrop #3759

Merged
merged 2 commits into from
Apr 26, 2024
Merged

Conversation

simonguo
Copy link
Member

fix: #3757

Copy link

codesandbox bot commented Apr 23, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

vercel bot commented Apr 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rsuite-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 23, 2024 9:46am
rsuite-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 23, 2024 9:46am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
rsuite-v4 ⬜️ Ignored (Inspect) Visit Preview Apr 23, 2024 9:46am

Copy link

codesandbox-ci bot commented Apr 23, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

codecov bot commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.76%. Comparing base (e065adf) to head (0b3604b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3759   +/-   ##
=======================================
  Coverage   93.76%   93.76%           
=======================================
  Files         655      655           
  Lines       22631    22631           
  Branches     3081     3081           
=======================================
  Hits        21219    21219           
  Misses        723      723           
  Partials      689      689           
Flag Coverage Δ
ChromeCi 93.71% <ø> (ø)
Firefox 93.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JuanCaCode
Copy link

when is this going to be merged? U.u

@simonguo simonguo merged commit 930a321 into main Apr 26, 2024
16 checks passed
@simonguo simonguo deleted the fix/Fade branch April 26, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SelectPicker doesn't work properly when it's inside a Drawer with the backdrop={false}
2 participants