Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(steps): center align inner icon/text #3811

Merged
merged 1 commit into from
May 17, 2024

Conversation

ShrinidhiUpadhyaya
Copy link
Contributor

Description

The icon inside steps is not vertically centered.

Current behavior

image

New behavior

image

Additional Information

If the PR gets accepted please use my GitHub email-id (shrinidhiupadhyaya1195@gmail.com) instead of my other email-id for the Co-authored-by: message.

Copy link

codesandbox bot commented May 16, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

vercel bot commented May 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rsuite-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2024 1:39am
rsuite-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2024 1:39am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
rsuite-v4 ⬜️ Ignored (Inspect) Visit Preview May 17, 2024 1:39am

Copy link

vercel bot commented May 16, 2024

Someone is attempting to deploy a commit to the rsuite Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.20%. Comparing base (2650886) to head (245edbe).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3811   +/-   ##
=======================================
  Coverage   94.20%   94.20%           
=======================================
  Files         699      699           
  Lines       23236    23236           
  Branches     3106     3106           
=======================================
  Hits        21889    21889           
  Misses        675      675           
  Partials      672      672           
Flag Coverage Δ
ChromeCi 94.15% <ø> (ø)
Firefox 93.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants