Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Sidenav): remove underline on hovered SidenavItem #2118

Merged
merged 1 commit into from Nov 12, 2021

Conversation

SevenOutman
Copy link
Member

@SevenOutman SevenOutman commented Nov 8, 2021

Before
image

After
image

@vercel
Copy link

vercel bot commented Nov 8, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

rsuite-v4 – ./docs

🔍 Inspect: https://vercel.com/rsuite/rsuite-v4/2xguRPrGw1iiiT7SKwEciESCWhKa
✅ Preview: Canceled

rsuite – ./

🔍 Inspect: https://vercel.com/rsuite/rsuite/zCuRVXcVZjpzSddasMBgYA5dJWX1
✅ Preview: https://rsuite-git-fix-sidenav-underline-rsuite.vercel.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 8, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit de5366d:

Sandbox Source
rsuite-tp-ci Configuration

@codecov
Copy link

codecov bot commented Nov 8, 2021

Codecov Report

Merging #2118 (de5366d) into main (64b7d68) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2118   +/-   ##
=======================================
  Coverage   85.27%   85.27%           
=======================================
  Files         266      266           
  Lines        8389     8389           
  Branches     2286     2286           
=======================================
  Hits         7154     7154           
  Misses        693      693           
  Partials      542      542           
Flag Coverage Δ
ChromeCi 85.17% <ø> (ø)
Firefox 85.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64b7d68...de5366d. Read the comment docs.

@SevenOutman SevenOutman merged commit 56f7c3a into main Nov 12, 2021
@SevenOutman SevenOutman deleted the fix/sidenav-underline branch November 12, 2021 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants