Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(styles): simplify compound selectors over 4 levels #2282

Merged
merged 6 commits into from
Jan 13, 2022

Conversation

SevenOutman
Copy link
Member

@SevenOutman SevenOutman commented Jan 6, 2022

Simplify over-complex compound selectors

Related components

  • CheckTree/CheckTreePicker
  • Tree/TreePicker
  • InputPicker/TagPicker
  • Sidenav

Changed selectors

Before After
.rs-check-tree-without-children .rs-check-tree-node-label .rs-check-item .rs-checkbox-checker > label .rs-checkbox-wrapper .rs-check-tree-without-children .rs-check-item .rs-checkbox-checker .rs-checkbox-wrapper
.rs-check-tree-node-all-uncheckable > .rs-check-tree-node-label .rs-check-item .rs-checkbox-checker > label .rs-check-tree-node-all-uncheckable > .rs-check-item . rs-checkbox-checker > label
.rs-tree-node>.rs-tree-node-label>.rs-tree-node-label-content .rs-tree-node-label-content
.rs-tree-node.rs-tree-node-active>.rs-tree-node-label>.rs-tree-node-label-content .rs-tree-node-active .rs-tree-node-label-content
.rs-picker-input.rs-picker-tag .rs-picker-toggle.rs-btn~.rs-picker-tag-wrapper .rs-picker-search-input input .rs-picker-toggle.rs-btn ~ .rs-picker-tag-wrapper .rs-picker-search-input input
.rs-sidenav-collapse-in .rs-dropdown-item-submenu>.rs-dropdown-item-toggle>.rs-dropdown-item-toggle-icon .rs-sidenav-nav > .rs-dropdown .rs-dropdown-item-toggle-icon
.rs-sidenav-collapse-in .rs-dropdown .rs-dropdown-item.rs-dropdown-item-expand > .rs-dropdown-item-toggle > .rs-dropdown-item-toggle-icon .rs-sidenav-nav > .rs-dropdown .rs-dropdown-item-expand .rs-dropdown-item-toggle-icon

@vercel
Copy link

vercel bot commented Jan 6, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

rsuite-v4 – ./docs

🔍 Inspect: https://vercel.com/rsuite/rsuite-v4/3mPLp4sE3goGaPCj4CHoh2jpYaEo
✅ Preview: Canceled

[Deployment for 616e949 canceled]

rsuite-nextjs – ./docs

🔍 Inspect: https://vercel.com/rsuite/rsuite-nextjs/BMRozXQVF5nrpkckJrjmR4G2p2ve
✅ Preview: https://rsuite-nextjs-git-perf-reduce-compound-selectors-rsuite.vercel.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 6, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 616e949:

Sandbox Source
rsuite-tp-ci Configuration

@codecov
Copy link

codecov bot commented Jan 6, 2022

Codecov Report

Merging #2282 (616e949) into main (c09226e) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2282      +/-   ##
==========================================
+ Coverage   85.67%   85.69%   +0.01%     
==========================================
  Files         274      274              
  Lines        8578     8576       -2     
  Branches     2381     2379       -2     
==========================================
  Hits         7349     7349              
  Misses        666      666              
+ Partials      563      561       -2     
Flag Coverage Δ
ChromeCi 85.66% <ø> (+0.01%) ⬆️
Firefox 85.66% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/MultiCascader/MultiCascader.tsx 77.24% <0.00%> (ø)
src/Dropdown/DropdownMenu.tsx 93.18% <0.00%> (+4.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c09226e...616e949. Read the comment docs.

@SevenOutman SevenOutman changed the title perf(styles): reduce compound selector to 5 levels perf(styles): simplify compound selectors over 5 levels Jan 6, 2022
@SevenOutman SevenOutman force-pushed the perf/reduce-compound-selectors branch from 6c86678 to 60ca9d6 Compare January 6, 2022 07:56
@vercel vercel bot temporarily deployed to Preview – rsuite-v4 January 6, 2022 07:56 Inactive
@SevenOutman SevenOutman changed the title perf(styles): simplify compound selectors over 5 levels perf(styles): simplify compound selectors over 4 levels Jan 6, 2022
@vercel vercel bot temporarily deployed to Preview – rsuite-v4 January 6, 2022 09:10 Inactive
Copy link
Member

@simonguo simonguo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sidenav 子选项存在对齐问题
image

@SevenOutman
Copy link
Member Author

已修复

@SevenOutman SevenOutman merged commit 304e8da into main Jan 13, 2022
@SevenOutman SevenOutman deleted the perf/reduce-compound-selectors branch January 13, 2022 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants