Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(InputNumber): make plus/minus buttons un-focusable #2398

Merged
merged 1 commit into from Mar 18, 2022

Conversation

SevenOutman
Copy link
Member

@SevenOutman SevenOutman commented Mar 15, 2022

Tab sequence before

2022-03-15.11.07.44.mov

Tab sequence after

2022-03-15.11.08.42.mov

@vercel
Copy link

vercel bot commented Mar 15, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

rsuite-v4 – ./docs

🔍 Inspect: https://vercel.com/rsuite/rsuite-v4/323CPc6eYYoBN8BV49jw7tzRbScT
✅ Preview: Canceled

rsuite-nextjs – ./docs

🔍 Inspect: https://vercel.com/rsuite/rsuite-nextjs/AL3wRYV33fg9rpkczyfnKCfW85N4
✅ Preview: https://rsuite-nextjs-git-perf-inputnumber-addon-unfocusable-rsuite.vercel.app

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c583087:

Sandbox Source
rsuite-tp-ci Configuration

@codecov
Copy link

codecov bot commented Mar 15, 2022

Codecov Report

Merging #2398 (c583087) into main (7b5a195) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2398   +/-   ##
=======================================
  Coverage   85.56%   85.56%           
=======================================
  Files         274      274           
  Lines        8647     8647           
  Branches     2428     2428           
=======================================
  Hits         7399     7399           
  Misses        659      659           
  Partials      589      589           
Flag Coverage Δ
ChromeCi 85.54% <ø> (ø)
Firefox 85.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/InputNumber/InputNumber.tsx 93.06% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b5a195...c583087. Read the comment docs.

@SevenOutman SevenOutman merged commit ab4c721 into main Mar 18, 2022
@SevenOutman SevenOutman deleted the perf/InputNumber-addon-unfocusable branch March 18, 2022 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants