Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DateRangePicker): fix Ok button not clickable #2564

Merged
merged 1 commit into from Jun 30, 2022

Conversation

simonguo
Copy link
Member

fix #2553

@vercel
Copy link

vercel bot commented Jun 28, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
rsuite-nextjs ✅ Ready (Inspect) Visit Preview Jun 28, 2022 at 2:25AM (UTC)
1 Ignored Deployment
Name Status Preview Updated
rsuite-v4 ⬜️ Ignored (Inspect) Jun 28, 2022 at 2:25AM (UTC)

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 15ed8f1:

Sandbox Source
rsuite-tp-ci Configuration

@codecov
Copy link

codecov bot commented Jun 28, 2022

Codecov Report

Merging #2564 (15ed8f1) into main (5be79c4) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2564      +/-   ##
==========================================
+ Coverage   85.30%   85.34%   +0.03%     
==========================================
  Files         293      293              
  Lines        9086     9087       +1     
  Branches     2554     2554              
==========================================
+ Hits         7751     7755       +4     
+ Misses        700      699       -1     
+ Partials      635      633       -2     
Flag Coverage Δ
ChromeCi 85.31% <100.00%> (+0.03%) ⬆️
Firefox 85.31% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/DateRangePicker/DateRangePicker.tsx 88.46% <100.00%> (+0.90%) ⬆️
src/Overlay/Overlay.tsx 87.09% <0.00%> (ø)
src/Overlay/Position.tsx 73.91% <0.00%> (ø)
src/Overlay/OverlayTrigger.tsx 64.17% <0.00%> (ø)
src/Picker/PickerToggleTrigger.tsx 100.00% <0.00%> (ø)
src/DatePicker/Toolbar.tsx 92.85% <0.00%> (+3.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5be79c4...15ed8f1. Read the comment docs.

@SevenOutman SevenOutman merged commit f80f94d into main Jun 30, 2022
@SevenOutman SevenOutman deleted the fix/DateRangePicker-shortcut branch June 30, 2022 06:30
myNameIsDu pushed a commit to myNameIsDu/rsuite that referenced this pull request Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DateRangePicker: Ok button stays disabled selecting fixed range
2 participants