Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Modal): fix close button alignment and color #2973

Merged
merged 1 commit into from
Dec 15, 2022

Conversation

SevenOutman
Copy link
Member

  1. The close button should have been aligned with the title by their top edges, according to design materials.

image

  1. Add a hover color

@vercel
Copy link

vercel bot commented Dec 9, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
rsuite-nextjs ✅ Ready (Inspect) Visit Preview Dec 9, 2022 at 10:15AM (UTC)
1 Ignored Deployment
Name Status Preview Updated
rsuite-v4 ⬜️ Ignored (Inspect) Dec 9, 2022 at 10:15AM (UTC)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 9, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7c3d3b7:

Sandbox Source
rsuite-tp-ci Configuration

@codecov
Copy link

codecov bot commented Dec 9, 2022

Codecov Report

Base: 93.06% // Head: 93.07% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (7c3d3b7) compared to base (20af7a3).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2973   +/-   ##
=======================================
  Coverage   93.06%   93.07%           
=======================================
  Files         557      557           
  Lines       20004    20004           
  Branches     2717     2717           
=======================================
+ Hits        18617    18618    +1     
  Misses        734      734           
+ Partials      653      652    -1     
Flag Coverage Δ
ChromeCi 93.03% <ø> (+<0.01%) ⬆️
Firefox 92.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Animation/Transition.tsx 85.32% <0.00%> (+0.91%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@SevenOutman SevenOutman merged commit b1eb5b4 into main Dec 15, 2022
@SevenOutman SevenOutman deleted the fix/Modal-close-button-style branch December 15, 2022 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants