Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CSS transitions): improved duration of transitions #3016

Merged
merged 2 commits into from
Jan 12, 2023

Conversation

simonguo
Copy link
Member

@simonguo simonguo commented Jan 11, 2023

The meaning of animation transition is to make the interactive experience better, but if the transition duration is too long, it will feel unsmooth.

  • Improved the transition duration of Button, Nav, and Panel from 0.3s to 0.15s.
  • Removed transitions for pickers option and unused functions.

@vercel
Copy link

vercel bot commented Jan 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
rsuite-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 11, 2023 at 10:05AM (UTC)
1 Ignored Deployment
Name Status Preview Comments Updated
rsuite-v4 ⬜️ Ignored (Inspect) Jan 11, 2023 at 10:05AM (UTC)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 11, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1998103:

Sandbox Source
rsuite-tp-ci Configuration

@codecov
Copy link

codecov bot commented Jan 11, 2023

Codecov Report

Base: 93.26% // Head: 93.26% // No change to project coverage 👍

Coverage data is based on head (1998103) compared to base (d0a1f27).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3016   +/-   ##
=======================================
  Coverage   93.26%   93.26%           
=======================================
  Files         560      560           
  Lines       20064    20064           
  Branches     2718     2718           
=======================================
  Hits        18713    18713           
  Misses        702      702           
  Partials      649      649           
Flag Coverage Δ
ChromeCi 93.22% <ø> (ø)
Firefox 92.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Sidebar/test/SidebarStylesSpec.tsx 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@SevenOutman SevenOutman merged commit d1829da into main Jan 12, 2023
@SevenOutman SevenOutman deleted the improve/css-transition branch January 12, 2023 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants