Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add loading prop for all pickers #3444

Merged
merged 2 commits into from
Nov 10, 2023
Merged

feat: add loading prop for all pickers #3444

merged 2 commits into from
Nov 10, 2023

Conversation

simonguo
Copy link
Member

Copy link

vercel bot commented Nov 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rsuite-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 10, 2023 8:58am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
rsuite-v4 ⬜️ Ignored (Inspect) Visit Preview Nov 10, 2023 8:58am

Copy link

codesandbox-ci bot commented Nov 10, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b0285c4:

Sandbox Source
rsuite-tp-ci Configuration
rsuite-playground (forked) Issue #2983

Copy link

codecov bot commented Nov 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ae00f90) 93.42% compared to head (b0285c4) 93.44%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3444      +/-   ##
==========================================
+ Coverage   93.42%   93.44%   +0.02%     
==========================================
  Files         569      569              
  Lines       20399    20503     +104     
  Branches     2785     2785              
==========================================
+ Hits        19057    19160     +103     
  Misses        688      688              
- Partials      654      655       +1     
Flag Coverage Δ
ChromeCi 93.41% <100.00%> (+0.02%) ⬆️
Firefox 92.74% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/Cascader/Cascader.tsx 85.18% <ø> (ø)
src/Cascader/test/CascaderSpec.tsx 100.00% <100.00%> (ø)
src/CheckPicker/CheckPicker.tsx 85.47% <ø> (ø)
src/CheckPicker/test/CheckPickerSpec.tsx 100.00% <100.00%> (ø)
src/CheckTreePicker/CheckTreePicker.tsx 86.59% <ø> (ø)
src/CheckTreePicker/test/CheckTreePickerSpec.tsx 99.67% <100.00%> (+0.01%) ⬆️
src/DatePicker/DatePicker.tsx 94.19% <ø> (ø)
src/DatePicker/test/DatePickerSpec.tsx 100.00% <100.00%> (ø)
src/DateRangePicker/DateRangePicker.tsx 87.92% <ø> (ø)
src/DateRangePicker/test/DateRangePickerSpec.tsx 100.00% <100.00%> (ø)
... and 11 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@simonguo simonguo merged commit 3c5b2af into main Nov 10, 2023
14 checks passed
@simonguo simonguo deleted the fix/picker-loading branch November 10, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InputPicker minimum width is too large
1 participant