Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

增加 import 选项解析 #7

Merged
merged 2 commits into from
Mar 9, 2020
Merged

增加 import 选项解析 #7

merged 2 commits into from
Mar 9, 2020

Conversation

SevenOutman
Copy link
Member

主题配置增加 import 数组选项,表示需要引入的 LESS 文件。既支持了导入第三方库的 LESS 文件,也修复了配置中的 import 字段被处理成 @import 变量导致编译出错的问题。

@hiyangguo
Copy link
Member

@SevenOutman 为什么不直接在 content 中 @import 而要使用 import 选项呢?

@SevenOutman
Copy link
Member Author

@hiyangguo 正如为什么变量写在配置中而不是拼在 lessContent 中一样。比如考虑三个自定义主题分别引用三个不同的库,并且各自有一些变量重写,用 lessContent 函数根据 themeName 拼 @import 的确可以实现,但其实引用库的配置和变量重写一样,是构成主题的“配置”,应当写在主题配置文件里,而不是侵入 webpack 配置文件

@hiyangguo
Copy link
Member

@SevenOutman 我觉得你说的有道理。那你补一下测试用例吧。

@hiyangguo hiyangguo merged commit 44926da into master Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants